⚠️ No Changeset found

Latest commit: fbed6ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The last comment on the linked issue is from this time last year - is there not a better solution than having to edit an adapter at buildtime? Also is it a build or dev issue this is solving?

@ghostdevv I am trying to solve a build issue, but it would work for both build and dev. There has to be an export for Durable Object class in the worker file - and I do not see how I can achieve this otherwise. I'd be happy if someone would confirm that's the best way to do it as of now.

The PR doesn't seem to work for me currently but I think it's because you aren't doing anything with the read file. However IMO we should probably take advantage of esbuild by copying the durable objects file to ${tmp}/durableObjects.ts and in the entry doing export * from './durableObjects'. The copy from path can default to ./src/durableObjects.js (or .ts) or be given from options like you have now.

Something like

// Copy durable objects
if (options.durableObjects) {
	builder.copy(options.durableObjects, `${tmp}/durableObjects.ts`)
} else {
	builder.copy(`${files}/durableObjects.js`, `${tmp}/durableObjects.ts`)
	builder.copy('./src/durableObjects.ts', `${tmp}/durableObjects.ts`)
	builder.copy('./src/durableObjects.js', `${tmp}/durableObjects.js`)
}

wdyt?

Oh wow oops, I incorrectly copied my solution into PR. I have now amended the commit, please check it out!
I am not sure if there is need to copy with esbuild - after exports are embedded in the workers script they are successfully picked up in my Vite build. (I was able to successfully deploy a project with Durable Object binding)

@ghostdevv did you have a chance to check out the update?

I am still not sure the best way to copy everything across, so trying to get a second opinion there.Regardless we'd still need to support TypeScript ootb, and I think we should set the default file to src/durableObjects.js (or ts) since we don't usually put special files in lib.

Another thing that just occurred to me is that when we document this, we need to note that sk specific imports like $lib won't work here because esbuild doesn't know about them. Unless there is some way we can get vite to process the file.